[Webkit-unassigned] [Bug 70594] [GTK] Add helper function to set the loader client in WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70594





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-21 08:12:50 PST ---
(In reply to comment #2)
> (From update of attachment 111934 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111934&action=review
> 
> > Source/WebKit2/ChangeLog:5
> > +        [GTK] Add helper function to set the loader client in WebKitWebView
> > +        https://bugs.webkit.org/show_bug.cgi?id=70594
> > +
> 
> These checks are incredibly cheap. Is there some other problem?

g_return macros are not so cheap.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:68
> > -
> > -    webkitWebViewBaseCreateWebPage(WEBKIT_WEB_VIEW_BASE(webView), webkitWebContextGetWKContext(priv->context), 0);
> > +    WebPageProxy* page = webkitWebViewBaseCreateWebPage(WEBKIT_WEB_VIEW_BASE(webView), webkitWebContextGetWKContext(priv->context), 0);
> >  
> 
> It seems like instead of doing this manually we should be chaining up to the parent constructor. It's mentioned here that you should always chain up to the parent constructor: http://developer.gnome.org/gobject/stable/chapter-gobject.html#gobject-instantiation

This method is constructed, not constructor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.