[Webkit-unassigned] [Bug 66851] Fix CSSPrimitiveValue::cssText() to use StringBuilder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66851





--- Comment #27 from Darin Adler <darin at apple.com>  2011-10-21 07:47:52 PST ---
(From update of attachment 111955)
View in context: https://bugs.webkit.org/attachment.cgi?id=111955&action=review

If you want a patch to be reviewed, you need to set review+ on it.

> Source/JavaScriptCore/wtf/text/StringBuilder.h:82
> +    static inline unsigned getPrecision(int m_exponent, unsigned m_precision, unsigned digitsBeforeDecimalPoint)

The inline keyword here is not needed.

> Source/JavaScriptCore/wtf/text/StringBuilder.h:108
> +    {
> +            // #shift
> +            int p = 1;
> +            while (num[p+1] != '\0' && p <= shift && num[1] != '\0') {
> +                    num[ p ] = num[p+1];
> +                    num[p+1] = '.';
> +                    p++;
> +            }

This function is indented 8 rather than 4 space tab stops.

> Source/JavaScriptCore/wtf/text/StringBuilder.h:136
> +    void append(double d)

This large function should not be inlined in a header.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.