[Webkit-unassigned] [Bug 61558] iframe with scrolling=no incorrectly autoscrollable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61558





--- Comment #13 from Antonio Gomes <tonikitoo at webkit.org>  2011-10-21 06:54:52 PST ---
(From update of attachment 111565)
View in context: https://bugs.webkit.org/attachment.cgi?id=111565&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:1502
>> +                if (frameElt->scrollingMode() != ScrollbarAlwaysOff) {
> 
> it seems like "frameElt" can be 0 here if the "if" above fails.
> 
> frameElt is also not a recommended variable name.
> 
> also you are checking ownerElement three times.

unless we are seeing two different 'ownerElement's objects, it is being checked three times:

> if (renderer()->document() && renderer()->document()->ownerElement() && renderer()->document()->ownerElement()->renderer()) {

> Element* ownerElement = frameView->frame() ? frameView->frame()->ownerElement() : 0;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.