[Webkit-unassigned] [Bug 69403] [WK2] [GTK] WebKitTestRunner crashes with heap corruption

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 05:05:24 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69403


Alejandro G. Castro <alex at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109753|0                           |1
        is obsolete|                            |
 Attachment #109753|review?                     |
               Flag|                            |
 Attachment #111946|                            |review?
               Flag|                            |




--- Comment #4 from Alejandro G. Castro <alex at igalia.com>  2011-10-21 05:05:23 PST ---
Created an attachment (id=111946)
 --> (https://bugs.webkit.org/attachment.cgi?id=111946&action=review)
Proposed patch

Used the solution of adding the include to the prefix file. I've checked the option to add an #error in the Platform.h but we are not respecting the rule in JSC. Currently it is not a problem because those files do not use the DEFINES in Platform.h, so the code would be a little bit overkill in the my opinion to be added in this patch. I think we can check it in the future if we find this situation is common.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list