[Webkit-unassigned] [Bug 65542] Need support for dirname attribute
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 20 22:57:44 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=65542
--- Comment #7 from Rakesh <rakesh.kn at motorola.com> 2011-10-20 22:57:44 PST ---
(In reply to comment #6)
> (From update of attachment 111386 [details])
> r- because of test coverage.
>
>
> View in context: https://bugs.webkit.org/attachment.cgi?id=111386&action=review
>
> > Source/WebCore/html/HTMLTextFormControlElement.cpp:584
> > + TextDirection textDirection = directionalityIfhasDirAutoAttribute(isAuto);
> > + if (isAuto)
> > + dir = String(textDirection == RTL ? "rtl" : "ltr");
> > + else if (hasAttribute(dirAttr))
> > + dir = getAttribute(dirAttr).string();
> > + else
> > + dir = String("ltr");
>
> I don't know this is a right code to detect direction of the value.
> Does any WebKit RTL expert have comment on this?
>
Yes, RTL expert can comment on this.
> > Source/WebCore/html/HTMLTextFormControlElement.h:82
> > + String dirNameAttributeFormData() const;
>
> I think the function name is not reasonable. How about formDataDirection(), or directionForFormData()?
directionForFormData() looks better to me.
> The test coverage is too low. We need to test
> * <input> and <textarea>
> * The target element has no dir attribute, dir=rtl, dir=ltr, dir=invalid.
> * The target element has no dir attribute but an ancestor element has dir= attribute.
> * The target element has RTL value, and LTR value with/without dir= attribtue.
Ok, will cover this tests too.
Thanks for taking time to review.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list