[Webkit-unassigned] [Bug 70468] DFG call optimization handling will fail if the call had been unlinked due to the callee being optimized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70468





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2011-10-20 21:29:14 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 111720 [details] [details])
> > lastSeenCallee isn't marked so this isn't safe, but also this may result in dead functions being kept alive longer than is strictly necessary.  I would almost consider going with a Weak<> ref rather than WriteBarrier<JSFunction> if we can get do it without a perf impact
> 
> I'll change it to use the WeakReferenceHarvester approach.

Changed my mind.  As per earlier discussions, using a strong reference would not be a regression.  We currently unlink calls when we blow away all code.  If we blow away all code, then this reference (lastSeenCallee) would disappear from the GC trace since its owned by CodeBlock.

It's definitely worthwhile to make all stubs into weak references, and when they go stale, blow away the stubs.  Or in the case of DFG optimized code, trigger recompilation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.