[Webkit-unassigned] [Bug 70459] Page Scale Factor broken when navigating history on pages with child frames

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70459


Fady Samuel <fsamuel at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|fsamuel at chromium.org        |webkit-unassigned at lists.web
                   |                            |kit.org




--- Comment #2 from Fady Samuel <fsamuel at chromium.org>  2011-10-20 17:26:28 PST ---
With frameScaleFactor now always returning 1.0 for subframes and pageScaleFactor for the mainFrame, and there being only a single pageScaleFactor, history for scaling is broken. 

Scaling history is saved on a per frame basis but restored, overriding the per-page pageScaleFactor multiple times. As a result, sometimes pages that should be scaled end up getting a scale factor of 1.0. 

The easy solution is only restore pageScaleFactor for the main frame, but I'm not satisfied with this solution. We need to change the names of methods in HistoryItem to correspond to the reality that these are frameScaleFactors and not pageScaleFactors. But given that all frames except the main frame have a scale factor of 1.0, does it even make sense to store this information?

Is there a global level History object where I should be storing pageScaleFactor?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.