[Webkit-unassigned] [Bug 70533] [Chromium] Cull occluded tiles in tiled layers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70533





--- Comment #5 from Adrienne Walker <enne at google.com>  2011-10-20 13:21:50 PST ---
(From update of attachment 111820)
View in context: https://bugs.webkit.org/attachment.cgi?id=111820&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:300
> +            if (child->opaque() && child->opacity() >= 0.9999 && childRenderSurface->drawOpacity() >= 0.9999)
> +                layer->addOccludedArea(enclosingIntRect(childRenderSurface->drawableContentRect()));
>          } else {
>              IntRect drawableContentRect = layer->drawableContentRect();
>              drawableContentRect.unite(child->drawableContentRect());
>              layer->setDrawableContentRect(drawableContentRect);
> +
> +            if (child->opaque() && child->opacity() >= 0.9999 && child->drawOpacity() >= 0.9999)

I am not sure about this logic. Am I reading this code correctly that only a layer's direct child can occlude that layer, but not any other layers? Shouldn't it be the case that a layer is a potential occluder for all layers that draw before it so long as all of those layers are going into the same render surface? So, later siblings can occlude earlier siblings and children can occlude grandparents?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.