[Webkit-unassigned] [Bug 64823] <svg> fails to use explicit width and height inside <html> inside IFRAME

Thu Oct 20 11:58:29 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=64823

--- Comment #22 from Levi Weintraub <leviw at chromium.org>  2011-10-20 11:58:28 PST ---
(From update of attachment 111666)
View in context: https://bugs.webkit.org/attachment.cgi?id=111666&action=review

>> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:139
>> +}
> 
> Just realized that passing around ownerRenderer is unnecessary.
> 
> static inline bool isEmbeddedThroughFrameContainingSVGDocument(const Frame* frame)
> {
>     ASSERT(frame);
>     ASSERT(frame->document());
>     // If our frame has an owner renderer, we're embedded through eg. object/embed/iframe,
>     // but we only negotiate if we're in an SVG document.
>     return !frame->ownerRenderer() || !frame->document()->isSVGDocument();
> }

I passed it in to save a call since ownerRenderer() has some logic and isn't inlined. Doesn't matter a whole lot though.

>> LayoutTests/ChangeLog:11
>> +        * svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
> 
> In theory this could be a cross-platform test, but it creates problems - see the commit queue failure.
> Currently we don't have any pixel test results (expected.png) or render tree dumps (expected.txt) in svg/as-object. So you better move these results to platform/mac/svg/as-object, in case you generated them on a mac, which I assume.

Yeah, no such luck. Fixing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.