[Webkit-unassigned] [Bug 70103] [chromium] Implement position:fixed in compositor thread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70103





--- Comment #10 from Vangelis Kokkevis <vangelis at chromium.org>  2011-10-20 09:33:39 PST ---
(From update of attachment 111788)
View in context: https://bugs.webkit.org/attachment.cgi?id=111788&action=review

> WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:91
> +    return getParentScrollDelta(layer->parent()) + layer->scrollDelta();

We should only be compensating for scrollDelta of the closest enclosing scrolling frame, not all of them.

> WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:184
> +        position += getParentScrollDelta(layer->parent());

I'm afraid I may have mislead you with my previous comments.  You'll need to first transform the frame's scroll delta to the layer's coordinate system before adjusting the position.  What you have here won't work if, for example, one of the ancestors of the fixed position layer is rotated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.