[Webkit-unassigned] [Bug 70484] [WK2] Enable pixel test on WK2 if expected.png exists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70484


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111789|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Ojan Vafai <ojan at chromium.org>  2011-10-20 09:30:25 PST ---
(From update of attachment 111789)
View in context: https://bugs.webkit.org/attachment.cgi?id=111789&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:289
> +        optparse.make_option("--wk2-pixel-test", action="store_true",
> +            dest="wk2_pixel_test", help="Enable pixel-to-pixel PNG comparisons on WebKit2"),

Why not just reuse --pixel? You already know if you're webkit2 from the driver_name. Seems like you could simplify this patch a lot if you did so.

If there's a reason you need a new flag, you should explain it in the changelog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.