[Webkit-unassigned] [Bug 61558] iframe with scrolling=no incorrectly autoscrollable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61558


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111565|review?                     |review-
               Flag|                            |




--- Comment #11 from Antonio Gomes <tonikitoo at webkit.org>  2011-10-20 06:54:03 PST ---
(From update of attachment 111565)
View in context: https://bugs.webkit.org/attachment.cgi?id=111565&action=review

> Source/WebCore/rendering/RenderLayer.cpp:1502
> +                HTMLFrameElement* frameElt = 0;
> +                Element* ownerElement = frameView->frame() ? frameView->frame()->ownerElement() : 0;
> +
> +                if (ownerElement && (ownerElement->hasTagName(frameTag) || ownerElement->hasTagName(iframeTag))) 
> +                    frameElt = static_cast<HTMLFrameElement*>(ownerElement);
> +
> +                if (frameElt->scrollingMode() != ScrollbarAlwaysOff) {

it seems like "frameElt" can be 0 here if the "if" above fails.

frameElt is also not a recommended variable name.

also you are checking ownerElement three times.

> Source/WebCore/rendering/RenderLayer.cpp:1504
> +                    LayoutRect r = getRectToExpose(viewRect, rect, alignX, alignY);

'r' is not a recommended variable name, althoug I know you are just moving existing code to within an "if" block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.