[Webkit-unassigned] [Bug 69137] In input field caret is not blinking after context menu hide

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69137





--- Comment #24 from chandra shekar vallala <chandra.vallala at motorola.com>  2011-10-20 02:09:03 PST ---
(In reply to comment #23)
> By the way since your patch doesn't actually fix this bug, you should file a new bug and make this bug depend it then upload your patch on that new(In reply to comment #22)
> (From update of attachment 111734 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111734&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:2262
> > +void respondToContextMenuShown()
> 
> We probably need to suspend caret blinking before showing context menu, so I'd rename this function to willShowContextMenu.

We are not sure of showing the context menu on every right click since there can be default prevent for context. If we call willShowContextMenu before context menu show from webkit layer there might be no context menu close notify from browser. The issue will exist again ....

> 
> Also, you're missing EventHandler::.
> 
> > Source/WebCore/page/EventHandler.cpp:2267
> > +void respondToContextMenuDismissed()
> 
> Nit: s/respondToContextMenuDismissed/respondToContextMenuDismissal/.
> 
> Ditto about missing EventHandler:: r- because of this.

Sorry, I uploaded a wrong patch...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.