[Webkit-unassigned] [Bug 70474] [Forms][File] Add tooltip to "No file selected" text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70474


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111739|review?                     |review-
               Flag|                            |




--- Comment #8 from Kent Tamura <tkent at chromium.org>  2011-10-20 01:40:50 PST ---
(From update of attachment 111739)
View in context: https://bugs.webkit.org/attachment.cgi?id=111739&action=review

> Source/WebCore/ChangeLog:25
> +        * html/FileInputType.cpp:
> +        (WebCore::FileInputType::getToolTip):
> +        * html/FileInputType.h:
> +        * html/HTMLInputElement.cpp:
> +        (WebCore::HTMLInputElement::getToolTip):
> +        * html/HTMLInputElement.h:
> +        * html/InputType.cpp:
> +        (WebCore::InputType::getToolTip):
> +        * html/InputType.h:
> +        * page/Chrome.cpp:
> +        (WebCore::Chrome::setToolTip):

Please write what is changed for each of files/functions as possible.

> Source/WebCore/html/HTMLInputElement.h:236
> +    String getToolTip() const;
> +

Please see item 6 and 7 of 'Names' section of http://www.webkit.org/coding/coding-style.html.
This function should be toolTip()", not getToolTip().

Also, I think defaultToolTip() or fallbackToolTip() is better.

> Source/WebCore/html/InputType.h:241
> +    virtual String getToolTip() const;

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.