[Webkit-unassigned] [Bug 69137] In input field caret is not blinking after context menu hide

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69137


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111734|review?                     |review-
               Flag|                            |




--- Comment #22 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-20 00:54:05 PST ---
(From update of attachment 111734)
View in context: https://bugs.webkit.org/attachment.cgi?id=111734&action=review

> Source/WebCore/page/EventHandler.cpp:2262
> +void respondToContextMenuShown()

We probably need to suspend caret blinking before showing context menu, so I'd rename this function to willShowContextMenu.

Also, you're missing EventHandler::.

> Source/WebCore/page/EventHandler.cpp:2267
> +void respondToContextMenuDismissed()

Nit: s/respondToContextMenuDismissed/respondToContextMenuDismissal/.

Ditto about missing EventHandler:: r- because of this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.