[Webkit-unassigned] [Bug 70440] [Chromium] Export missing symbols from Web*Layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70440





--- Comment #4 from Antoine Labour <piman at chromium.org>  2011-10-19 22:17:59 PST ---
(In reply to comment #3)
> (From update of attachment 111673 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111673&action=review
> 
> > Source/WebKit/chromium/public/WebContentLayer.h:38
> > +class WEBKIT_EXPORT WebContentLayer : public WebLayer {
> 
> we don't normally export entire classes.  see other header files.  we just export the non-inline methods (ignore pure virtual methods of course).

That was necessary, otherwise I was getting undefined symbols for the vtable - it's defined with the first virtual method definition (in this case the destructor, inside of the .so), but is needed in the constructor (inlined in the calling code).
If we're adamant on that, we could try inlining the virtual destructor, or un-inlining the constructors and moving them into the .cpp. I'll see if either one works.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.