[Webkit-unassigned] [Bug 68969] need iframe shim support for Gtk webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 21:53:15 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68969





--- Comment #10 from jane.xia2009 at gmail.com  2011-10-19 21:53:15 PST ---
(In reply to comment #8)
> Oh, by the way, once you have uploaded your patch, set the review flag to ? and the commit-queue flag to ?. This says: "This patch needs a review and if it passes review should be landed by the commit bot."

I test my build with iframe-shims.html in LayoutTests/plugins/iframe-shims.html and it works.(In reply to comment #7)
> (From update of attachment 111572 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111572&action=review
> 
> Thanks for your contribution! This looks like a good change. Are there any tests that cover it that we can unskip? Your patch is also missing a ChangeLog, see http://www.webkit.org/coding/contributing.html.
> 
> > Source/WebCore/plugins/gtk/PluginViewGtk.cpp:568
> > +		// Cut out areas of the plugin occluded by iframe shims
> > +		Vector<IntRect> cutOutRects;
> > +		getPluginOcclusions(m_element, this->parent(), frameRect(), cutOutRects);
> 
> You indentation looks off here. Be sure to use spaces. All comments that are complete sentences should end with a period.
> 
> > Source/WebCore/plugins/gtk/PluginViewGtk.cpp:574
> > +				cutOutRects[i].move(-frameRect().x(), -frameRect().y());
> > +				GdkRectangle cutOutRect=cutOutRects[i];
> > +				gdk_region_subtract(clipRegion,gdk_region_rectangle(&cutOutRect));
> 
> Looks like the indentation is off below as well.

Thanks, I've changed the comment and the indentation.You can unskip iframe-shims.html in LayoutTests/plugins/iframe-shims.html to test it, I run this case by hand. I didn't see any test case available for iframe shims in Gtk webkit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list