[Webkit-unassigned] [Bug 69997] [Chromium] Reduce dependencies of ImageDiff to compile it for Android.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 19:48:12 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69997





--- Comment #10 from Hao Zheng <zhenghao at chromium.org>  2011-10-19 19:48:12 PST ---
(In reply to comment #8)
> (From update of attachment 111580 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111580&action=review
> 
> I think we should just depend on wtf because it's pretty small.  Or are you trying to avoid having host and target in JavaScriptCore.gyp?

No, it's because wtf would depend on icu, which in turn would depend on others...

> 
> > Tools/DumpRenderTree/chromium/ImageDiff.cpp:51
> > +#include <limits.h>
> 
> I would just include this on all platforms if a single platform needs it.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list