[Webkit-unassigned] [Bug 70395] REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70395





--- Comment #4 from Xiaomei Ji <xji at chromium.org>  2011-10-19 16:56:10 PST ---
The condition at following line seems wrong to me.
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/ScrollView.cpp#L587
I think we should compare adjustScrollPositionWithinRange(IntPoint(desiredOffset)) with scrollPosition() which are in the same coordinates (both negative for RTL pages).

After which, we do not (and should not) need to check the condition anymore in ScrollAnimator::scrollToOffsetWithoutAnimation().

I will need to run chromium's test case tony mentioned in #3.


Index: ScrollAnimator.cpp
===================================================================
--- ScrollAnimator.cpp  (revision 96967)
+++ ScrollAnimator.cpp  (working copy)
@@ -74,11 +74,11 @@

 void ScrollAnimator::scrollToOffsetWithoutAnimation(const FloatPoint& offset)
 {
-    if (m_currentPosX != offset.x() || m_currentPosY != offset.y()) {
+    //if (m_currentPosX != offset.x() || m_currentPosY != offset.y()) {
         m_currentPosX = offset.x();
         m_currentPosY = offset.y();
         notifyPositionChanged();
-    }
+    //}
 }

 bool ScrollAnimator::handleWheelEvent(const PlatformWheelEvent& e)
Index: ScrollView.cpp
===================================================================
--- ScrollView.cpp      (revision 96967)
+++ ScrollView.cpp      (working copy)
@@ -582,7 +582,8 @@
     }

     IntPoint scrollPoint = adjustScrollPositionWithinRange(IntPoint(desiredOffs
et)) + IntSize(m_scrollOrigin.x(), m_scrollOrigin.y());
-    if (scrollPoint != scrollPosition())
+//    if (scrollPoint != scrollPosition())
+    if (adjustScrollPositionWithinRange(IntPoint(desiredOffset)) != scrollPosit
ion())
         ScrollableArea::scrollToOffsetWithoutAnimation(scrollPoint);

     // Make sure the scrollbar offsets are up to date.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.