[Webkit-unassigned] [Bug 69295] Web Inspector: reimplement protocol backend/frontend source generator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69295





--- Comment #34 from Peter Rybin <peter.rybin at gmail.com>  2011-10-19 12:56:33 PST ---
(In reply to comment #32)
> (From update of attachment 111279 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111279&action=review
> 
> > Source/WebCore/inspector/CodeGeneratorInspector.py:265
> > +        def getCParamType(cls, param_type, optional):
> > +            if (param_type == ParamType.EVENT):
> > +                if optional:
> > +                    return cls._ref_c_type
> > +                else:
> > +                    return cls._plain_c_type
> > +            else:
> > +                return cls._plain_c_type
> 
> I'm a bit confused by the mix of styles in this script.
> I'd like to see the names of methods, member variables, etc formatted according to WebKit style guide.

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.