[Webkit-unassigned] [Bug 69249] [GTK][WEBKIT2] Add webkit_web_view_load_html and webkit_web_view_load_plain_text APIs

Wed Oct 19 09:10:35 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69249

--- Comment #24 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-19 09:10:35 PST ---
(From update of attachment 110117)
View in context: https://bugs.webkit.org/attachment.cgi?id=110117&action=review

Patch looks good to me, I think you just need to update it to current git master and use the new unit tests stuff. Look at how load_alternate_content is tested in TestWebKitWebLoaderClient.cpp and add somethihng similar for html and plain_text. Thanks!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:257
> + * @base_uri: the base URI for relative locations. If %NULL, defaults to about:blank.

add an introspection tag to indicate that base_uri can be null:

@base_uri: (allo-none): the base URI for relative locations or %NULL.

and move the comment that when null it defaults to about:blank below to the main doc body.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.