[Webkit-unassigned] [Bug 68969] need iframe shim support for Gtk webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68969





--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-10-19 07:19:14 PST ---
(From update of attachment 111572)
View in context: https://bugs.webkit.org/attachment.cgi?id=111572&action=review

Thanks for your contribution! This looks like a good change. Are there any tests that cover it that we can unskip? Your patch is also missing a ChangeLog, see http://www.webkit.org/coding/contributing.html.

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:568
> +		// Cut out areas of the plugin occluded by iframe shims
> +		Vector<IntRect> cutOutRects;
> +		getPluginOcclusions(m_element, this->parent(), frameRect(), cutOutRects);

You indentation looks off here. Be sure to use spaces. All comments that are complete sentences should end with a period.

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:574
> +				cutOutRects[i].move(-frameRect().x(), -frameRect().y());
> +				GdkRectangle cutOutRect=cutOutRects[i];
> +				gdk_region_subtract(clipRegion,gdk_region_rectangle(&cutOutRect));

Looks like the indentation is off below as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.