[Webkit-unassigned] [Bug 70404] [EFL] Implement port layer of keygen element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70404


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111579|review?                     |review-
               Flag|                            |




--- Comment #5 from Leandro Pereira <leandro at profusion.mobi>  2011-10-19 06:59:55 PST ---
(From update of attachment 111579)
View in context: https://bugs.webkit.org/attachment.cgi?id=111579&action=review

Informal r- for the reasons below.

> Source/WebCore/platform/efl/SSLKeyGeneratorEfl.cpp:84
> +    if (!(RSA_check_key(rsa) == 1))
> +        return SSLErrorHandler(rsa, pkey, spki);

if (RSA_check_key(rsa) != 1) ...

> Source/WebCore/platform/efl/SSLPrivateKeyStoreEfl.cpp:35
> +static SSLPrivateKeyStoreEfl* s_SSLPrivateKeyStoreEfl = 0;
> +static Mutex s_SSLPrivateKeyStoreMutex;

These can be declared inside SSLPrivateKeyStoreEfl::getInstance() below, using the DECLARE_STATIC_LOCAL() macro.

> Source/cmake/FindSSL.cmake:15
> +  NAMES openssl/ssl.h

It would be nice if a GNUTLS implementation were also provided, so that if GNUTLS is being used by the networking backend (by libcurl or libsoup), there's no need to link to both OpenSSL and GNUTLS libraries.

> Source/cmake/OptionsEfl.cmake:39
> +FIND_PACKAGE(SSL REQUIRED)

I'd rather not mark this as required, but condition it to a build-time option.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.