[Webkit-unassigned] [Bug 64970] [Gtk] Support for client-based geolocation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64970





--- Comment #29 from Zan Dobersek <zandobersek at gmail.com>  2011-10-19 01:53:07 PST ---
(In reply to comment #28)
> The build has been hardcoded to depend on geolocation, but geolocation is not enabled by default in configure.ac. Things now fail with:
> 
> In file included from ../../Source/WebKit/gtk/WebCoreSupport/GeolocationClientGtk.cpp:22:0:
> ../../Source/WebKit/gtk/WebCoreSupport/GeolocationClientGtk.h:27:36: fatal error: geoclue/geoclue-master.h: No such file or directory
> compilation terminated.
> make[1]: *** [Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-GeolocationClientGtk.lo] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make[1]: Leaving directory `/home/xan/git/webkit/build/normal'
> make: *** [install] Error 2
> 
> I believe things are missing ENABLE(GEOLOCATION) all over the place? Probably this works in the bots because build-webkit enables geolocation.

Sorry for the stupid mistake. You're right about the ENABLE flag, but rather than using ENABLE(GEOLOCATION) I'll post a patch that wraps things into ENABLE(CLIENT_BASED_GEOLOCATION). ENABLE_CLIENT_BASED_GEOLOCATION is defined only if geolocation is enabled, so that should be enough.

Patch coming soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.