[Webkit-unassigned] [Bug 70304] width/height attributes of input element should be supported when the type of the input element is image.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70304





--- Comment #12 from Dongwoo Joshua Im <dw.im at samsung.com>  2011-10-19 00:02:13 PST ---
(In reply to comment #11)
> (From update of attachment 111405 [details])
> Please add additional tests:
> 
> - setting value to a string that's not a valid non-negative integer (perhaps "5.5pt");

I will add this kind of test case.

> - setting value to a string representing a negative number specifically;

I will add this kind of test case.

> - changing width and height of non-image input elements (spec says that these attributes "do not apply" then, but what exactly does that mean?);

I will add this kind of test case.
In setter function, setAttribute function only be called when the type of input element take care of width and height. (the result of shouldRespectHeightAndWidthAttributes() is true)

> - how setting the value affects attributes (check node.getAttribute("width") in addition to node.width).

I will add this kind of test case.

> 
> Please verify that these tests have matching results in WebKit an in other browsers implementing this.

I will try.

> 
> Why this is not a [Reflect] attribute?

Regarding w3c spec (http://www.w3.org/TR/html5/the-map-element.html#attr-dim-width), width and height IDL attributes on the iframe, embed, object, and video elements must reflect the respective content attributes of the same name. 
But it does not say the width and height attributes of image and input element are reflect. And current implementation of the width and height attributes of image element are not [Reflect] attributes. 
And, some type of input element will not take care of the width and height attributes.
So, I think the width and height attributes of input element is not a [Reflect] attribute.

> 
> r- for test coverage. I don't know enough about this code to confidently review, but I suspect that this should use [Reflect].

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.