[Webkit-unassigned] [Bug 70299] Implement legacy text check emulation in unified text check interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70299


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111389|review?                     |review-
               Flag|                            |




--- Comment #2 from MORITA Hajime <morrita at google.com>  2011-10-18 23:05:38 PST ---
(From update of attachment 111389)
View in context: https://bugs.webkit.org/attachment.cgi?id=111389&action=review

> Source/WebCore/page/Settings.cpp:199
> +#if USE(UNIFIED_TEXT_CHECKING) || PLATFORM(CHROMIUM)

Let's do this at a separate change to allow revert easily
because this can cause some unexpected, hard-to-fix regression. (I hope not though.)

At this point, I recommend
- to add WebCore::Internals API to flip the flag, and
- to add some tests for our emulating code, especially with enabling this flag. The test would have
-- a test case for some non-whitespace segmentation
-- a test case containing multiple bad words
-- a test case containing a bad word which located at the beginning, middle, end of the paragraph.
-- a test case containing a valid word which contains a bad word as a substring.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.