[Webkit-unassigned] [Bug 69996] DFG should have inlining

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 18 16:50:51 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69996


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-10-18 16:50:51 PST ---
Attachment 111528 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGJITCompiler.h:444:  The parameter name "codeBlock" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGGraph.cpp:82:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/JavaScriptCore/dfg/DFGGraph.cpp:92:  Declaration has space between type name and & in Node &currentNode  [whitespace/declaration] [3]
Source/JavaScriptCore/dfg/DFGGraph.cpp:93:  Declaration has space between type name and & in Node &previousNode  [whitespace/declaration] [3]
Source/JavaScriptCore/runtime/Executable.h:577:  The parameter name "kind" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list