[Webkit-unassigned] [Bug 70360] Array.prototype methods missing exception checks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70360





--- Comment #3 from Gavin Barraclough <barraclough at apple.com>  2011-10-18 14:50:35 PST ---
I think having the helper actually hinders us here - since we need to force a return.  The obvious thing would be to make the helper return JSValue() if there is an exception, but it already uses this value to indicate property-not-present.

The best solution is likely to restructure the code to remove the helper, and make PropertySlot::getValue return JSValue() if an exception is thrown from a getter - but this is likely a bigger change, so I'm going to grab your r+ & run, and leave this refactoring for later!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.