[Webkit-unassigned] [Bug 69745] [GTK] Fix make distcheck build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 18 02:06:54 PDT 2011


--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-18 02:06:54 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > Thanks, but Xan told me he was not going to approve this patch in its current state, so I won't land it for now until make sure he agrees.
> > 
> > Since we are not releasing today I still think it's a mistake to land this given that no one seems to understand why it works or why it's needed. Gustavo said he'd try to have a look (since he was involved in the previous hack in wk1) and give feedback on the bug. If the makefiles are going to disappear (soon?) anyway I guess I don't care as much, but waiting for Gustavo's opinion still seems more sensible.
> My advice to Carlos was just to just land the obvious bits of this patch and save the gtkdoc stuff for later.

I can do that, but this bug is about fixing make distcheck, we should open a new bug for the gtk-doc stuff and rename this to something else, because without the gtk-doc stuff this patch doesn't fix distcheck.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list