[Webkit-unassigned] [Bug 69996] DFG should have inlining

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 17 22:20:46 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69996





--- Comment #1 from Filip Pizlo <fpizlo at apple.com>  2011-10-17 22:20:46 PST ---
Created an attachment (id=111381)
 --> (https://bugs.webkit.org/attachment.cgi?id=111381&action=review)
work in progress

If this even compiles, then clang is broken.

Still working on this.  Items that are (hopefully) done:

- Flushing state related to the call that can be reflectively accessed, like the arguments, and the callee.

- Determining when it is profitable to inline based on the classic heuristics (inlinee size, inline stack depth, recursion detection, rejection of fancy operations that the inliner won't handle correctly).

- Actually inlining code, with the following special things:

- Inlining calls to single-basic-block functions does not introduce any control flow, and so the only "evidence" that there was a call is the flushing of arguments and the callee.

- Inlining calls to functions with multiple basic blocks does the right thing.

- Inlining calls to functions that don't terminate does the right thing.

- Inlining calls to functions that have multiple return statements does the right thing.

Things that aren't done:

- OSR support.

- ???

- Make it compiler, pass tests, and produce speed-ups.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list