[Webkit-unassigned] [Bug 61287] [UNIX] Use SOCK_SEQPACKET when available

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61287


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94982|review?                     |review+
               Flag|                            |




--- Comment #37 from Darin Adler <darin at apple.com>  2011-10-17 12:39:28 PST ---
(From update of attachment 94982)
View in context: https://bugs.webkit.org/attachment.cgi?id=94982&action=review

>>> Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp:196
>>> +    }
>> 
>> I think the method call here makes the comment redundant.
> 
> Right, I added the comment because it's not obvious that a 0-byte read means the other end closed the connection, but the method name makes it clear, so I'll remove the comment

A comment you could leave in would be "// A zero byte read indicates that the other end closed the connection."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.