[Webkit-unassigned] [Bug 59863] Incomplete repaint with box-shadow and padding when Javascript updates document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59863


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95339|review?                     |review+
               Flag|                            |




--- Comment #16 from Darin Adler <darin at apple.com>  2011-10-17 12:16:37 PST ---
(From update of attachment 95339)
View in context: https://bugs.webkit.org/attachment.cgi?id=95339&action=review

> Source/WebCore/rendering/RenderObject.cpp:1300
> +    // insetShadowTop and insetShadowLeft are not used because the box didn't change its location

Needs a period.

Confusing comment because it describes the code below, not this code. I think instead of "are not used" you could say "will not be used below".

Or you could leave the comment out entirely.

> Source/WebCore/rendering/style/RenderStyle.h:1337
> +    void getShadowInsetExtent(const ShadowData*, int &top, int &right, int &bottom, int &left) const;

Same formatting problem. Notice the mismatch with the next line of code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.