[Webkit-unassigned] [Bug 64865] Switch isQuirkValue() virtual function to inline one.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 16 16:43:56 PDT 2011


--- Comment #38 from Luke Macpherson <macpherson at chromium.org>  2011-10-16 16:43:55 PST ---
(From update of attachment 111184)
View in context: https://bugs.webkit.org/attachment.cgi?id=111184&action=review

> Source/WebCore/css/CSSPrimitiveValue.h:257
> +    // This holds enum UnitType, so only 7 unsigned bits are necessary.

I would recommend adding a UnitTypeBits constant defined as 7, remove this comment, and use the constant here.
Also it would be good to add a COMPILE_ASSERT to the constructor of PrimitiveValue that asserts that its size never exceeds what you expect.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list