[Webkit-unassigned] [Bug 69295] Web Inspector: reimplement protocol backend/frontend source generator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69295


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110523|review?                     |review-
               Flag|                            |




--- Comment #26 from Pavel Feldman <pfeldman at chromium.org>  2011-10-16 10:54:37 PST ---
(From update of attachment 110523)
View in context: https://bugs.webkit.org/attachment.cgi?id=110523&action=review

Minor formal comments, otherwise code looks good.

> Source/WebCore/ChangeLog:3
> +        Web Inspector: reimplement protocol backend/frontend source generator

You should be more explicit wrt rationale of the change. I.e. port source generator from perl to python, explain why.

> Source/WebCore/ChangeLog:3178
> +2011-10-04  Peter Rybin  <peter.rybin at gmail.com>

You should nuke this

> Source/WebCore/ChangeLog:13819
> +2011-10-03  Peter Rybin  <peter.rybin at gmail.com>

ditto

> Source/WebCore/WebCore.gyp/WebCore.gyp:363
> +            '../inspector/CodeGeneratorInspector.py',

prefer <@(_inputs)

> Source/WebCore/inspector/CodeGeneratorInspector.py:493
> +    backend_h = string.Template("""// Copyright (c) 2010 The Chromium Authors. All rights reserved.

2011

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.