[Webkit-unassigned] [Bug 70101] Implement [Constructor] IDL for JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70101





--- Comment #6 from Kentaro Hara <haraken at chromium.org>  2011-10-16 04:44:19 PST ---
(From update of attachment 111010)
View in context: https://bugs.webkit.org/attachment.cgi?id=111010&action=review

>> Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h:91
>> +class JSTestInterfaceConstructor : public DOMConstructorObject {
> 
> I don't quite understand when this moved from the cpp file to the h file.

Currently, the declaration of XXXXConstructor exists on the h file if the constructor is a custom constructor, and on the cpp file if the constructor is not a custom constructor. This is inconsistent and I think that all declarations should exist on the h file.

Practical problem: For example, JSDOMWindowCustom.cpp assumes that the declaration of EventSourceConstructor exists on the h file. Currently, JSDOMWindowCustom.cpp can be compiled, since EventSourceConstructor is written as a custom constructor and thus it is declared on the h file. However, in a coming patch, I am planning to generate EventSourceConstructor by [Constructor] IDL, which will put the declaration to the cpp file (unless we move the declaration from the cpp file to the h file by this patch). This makes JSDOMWindowCustom.cpp fail to compile.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.