[Webkit-unassigned] [Bug 64865] Switch isQuirkValue() virtual function to inline one.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 16 02:41:32 PDT 2011


--- Comment #31 from David Barr <davidbarr at chromium.org>  2011-10-16 02:41:31 PST ---
(In reply to comment #30)
> (From update of attachment 111152 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111152&action=review
> Seems OK.
> > Source/WebCore/css/CSSPrimitiveValue.h:257
> > -    signed m_type : 31;
> > +    signed m_type : 30;
> Why is m_type bigger than it needs to be?

It takes values from enum CSSPrimitiveValue::UnitType, the maximum of which is presently
CSS_COUNTER_NAME = 109, so I think it only needs 7 unsigned bits.
However it began as an int even though it's always implicitly cast to short by its accessors.
One bit was borrowed for m_cachedCSSText in r59386 to resolve a substantially larger
memory regression but the extra bits were left assigned to m_type.
It seems Sam Weinig and I were both timid when shrinking it. Principal of least change perhaps?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list