[Webkit-unassigned] [Bug 64970] [Gtk] Support for client-based geolocation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 16 02:19:45 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64970





--- Comment #17 from Zan Dobersek <zandobersek at gmail.com>  2011-10-16 02:19:45 PST ---
(In reply to comment #16)
> (From update of attachment 110268 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110268&action=review
> 
> This looks great! I realized that since we need this code for WebKit2 also we'll have to share it anyway. We can tackle that later though. It only requires hoisting the code out into another class. Please fix the style nits before landing.
> 

All the nits are fixed, but I don't have commit access, so either someone else can push the patch or the commit queue is used. By the way, a complete rebuild is required.

> > Tools/Scripts/build-webkit:159
> > +      define => "ENABLE_CLIENT_BASED_GEOLOCATION", default => (isAppleWebKit() || isGtk()), value => \$clientBasedGeolocationSupport },
> 
> Hopefully this doesn't lead to a warning about an unknown parameter. If it does, it could mean our bots always build with warnings.

If you're having configure warnings in mind, by removing --enable-client-based-geolocation option the warnings will pop up anyway. As said before, it's just there to note that Gtk port uses this feature. Similarly enabled in build-webkit but not configurable in configure.ac is the ENABLE_INSPECTOR option, which then also causes unrecognized configure option warnings.

Thanks for the reviews!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list