[Webkit-unassigned] [Bug 70101] Implement [Constructor] IDL for JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70101





--- Comment #4 from Kentaro Hara <haraken at chromium.org>  2011-10-15 23:43:17 PST ---
(In reply to comment #2)
> (From update of attachment 111010 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111010&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3266
> > +                # We do not also support a constructor [Opitional] argument without CallWithDefaultValue.
> 
> Opitional <-- typo

Fixed. 

> > Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:111
> > +    ScriptExecutionContext* scriptContext = static_cast<JSDOMGlobalObject*>(exec->lexicalGlobalObject())->scriptExecutionContext();
> > +    if (!scriptContext)
> > +        return JSValue::encode(jsUndefined());
> 
> Why is this variable check needed?  It's not used in this function.

Removed this check.

> > Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:122
> > +    RefPtr<TestInterface> object = TestInterface::create(str1, str2, context, ec);
> 
> This seems to be passing context at the end instead of the beginning.

Sorry, fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.