[Webkit-unassigned] [Bug 64865] Switch isQuirkValue() virtual function to inline one.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64865


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111150|review?                     |review+
               Flag|                            |




--- Comment #26 from Darin Adler <darin at apple.com>  2011-10-15 15:19:30 PST ---
(From update of attachment 111150)
View in context: https://bugs.webkit.org/attachment.cgi?id=111150&action=review

> Source/WebCore/css/CSSPrimitiveValue.h:140
> +    /*
> +     * This value is used to handle quirky margins in reflow roots (body, td, and th) like WinIE.
> +     * The basic idea is that a stylesheet can use the value __qem (for quirky em) instead of em.
> +     * When the quirky value is used, if you're in quirks mode, the margin will collapse away
> +     * inside a table cell.
> +     */

We use "//" comments, not "/*" comments. Not sure why you changed this one.

> Source/WebCore/css/CSSPrimitiveValue.h:143
> +        CSSPrimitiveValue *ptr = new CSSPrimitiveValue(value, type);

The "*" goes next to the type, not the local variable name.

Instead of ptr this local variable should be named value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.