[Webkit-unassigned] [Bug 70157] FunctionExecutable should expose the ability to create unattached FunctionCodeBlocks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70157


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111108|review?                     |review+
               Flag|                            |




--- Comment #4 from Geoffrey Garen <ggaren at apple.com>  2011-10-14 17:10:57 PST ---
(From update of attachment 111108)
View in context: https://bugs.webkit.org/attachment.cgi?id=111108&action=review

r=me

> Source/JavaScriptCore/runtime/Executable.cpp:416
> +        return PassOwnPtr<FunctionCodeBlock>();

I think you can just return nullptr here.

> Source/JavaScriptCore/runtime/Executable.cpp:427
> +    result = adoptPtr(new FunctionCodeBlock(this, FunctionCode, globalObject, source().provider(), source().startOffset(), specializationKind == CodeForConstruct, PassOwnPtr<FunctionCodeBlock>()));

nullptr, or maybe just make that the default function argument.

> Source/JavaScriptCore/runtime/Executable.cpp:432
> +        return PassOwnPtr<FunctionCodeBlock>();

nullptr

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.