[Webkit-unassigned] [Bug 70101] Implement [Constructor] IDL for JSC
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 14 11:21:56 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=70101
--- Comment #2 from Adam Barth <abarth at webkit.org> 2011-10-14 11:21:56 PST ---
(From update of attachment 111010)
View in context: https://bugs.webkit.org/attachment.cgi?id=111010&action=review
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3266
> + # We do not also support a constructor [Opitional] argument without CallWithDefaultValue.
Opitional <-- typo
> Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:111
> + ScriptExecutionContext* scriptContext = static_cast<JSDOMGlobalObject*>(exec->lexicalGlobalObject())->scriptExecutionContext();
> + if (!scriptContext)
> + return JSValue::encode(jsUndefined());
Why is this variable check needed? It's not used in this function.
> Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:122
> + RefPtr<TestInterface> object = TestInterface::create(str1, str2, context, ec);
This seems to be passing context at the end instead of the beginning.
> Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h:91
> +class JSTestInterfaceConstructor : public DOMConstructorObject {
I don't quite understand when this moved from the cpp file to the h file.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list