[Webkit-unassigned] [Bug 67112] [EFL] Support requestAnimationFrame API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67112


Raphael Kubo da Costa <kubo at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110977|commit-queue?               |
               Flag|                            |




--- Comment #3 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-10-14 04:50:21 PST ---
(From update of attachment 110977)
View in context: https://bugs.webkit.org/attachment.cgi?id=110977&action=review

I've noticed you use different email addresses in the ChangeLog and in your Bugzilla account. Is that intentional? Do you know of any test (either a page on the internet or some page in LayoutTests) where I can see this feature working?

Still r? while waiting for the answers.

> ChangeLog:8
> +        Add build-option for reqeustAnimationFrame feature.

Typo in reqeustAnimationFrame.

>> Source/WebCore/CMakeLists.txt:2182
>> +IF (ENABLE_REQUEST_ANIMATION_FRAME)
> 
> Where is ENABLE_REQUEST_ANIMATION_FRAME defined?  Is IF (WTF_USE_REQUEST_ANIMATION_FRAME) correct?

Defined in Source/cmake/OptionsEfl.cmake below?

> Source/cmake/OptionsEfl.cmake:87
> +WEBKIT_FEATURE(ENABLE_REQUEST_ANIMATION_FRAME "Enable requestAnimationFrame API" DEFAULT OFF)

Any reason for it to be OFF by default?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.