[Webkit-unassigned] [Bug 69834] [GStreamer] WebAudio AudioFileReader implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 01:41:51 PDT 2011


--- Comment #19 from Philippe Normand <pnormand at igalia.com>  2011-10-14 01:41:51 PST ---
(In reply to comment #13)
> (From update of attachment 110867 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110867&action=review
> I'm not sure I understand why you export the AudioFileReader class in AudioFileReaderGStreamer.h. Will you be using from another class in a later patch? if not, might be better to simply stick the class definition in AudioFileReaderGstreamer.cpp and delete AudioFileReaderGStreamer.h.

Indeed no need to export that class!
Thanks for the reviews Martin, I uploaded a new patch taking in account your latest feedback :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list