[Webkit-unassigned] [Bug 69572] [Qt] QTouchWebView missing navigationPolicyForUrl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69572


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110864|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #16 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-10-14 01:29:40 PST ---
(From update of attachment 110864)
View in context: https://bugs.webkit.org/attachment.cgi?id=110864&action=review

We want to do this in a different way

> Source/WebKit2/ChangeLog:8
> +        Implemented navigationPolicyForUrl. This is similar to DesktopWebView implementation. It provides the flexibiltiy to specify custom navigation policies for TouchWebView.

Please break that line

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_navigationPolicyForUrl.qml:16
> +        function navigationPolicyForUrl(url, button, modifiers) {
> +            if (button == Qt.MiddleButton && modifiers & Qt.ControlModifier) {
> +                otherWebView.page.load(url)
> +                return TouchWebView.IgnorePolicy
> +            }
> +            return TouchWebView.UsePolicy
> +        }

We decided to do this differently. Simon had some better ideas. Please check the ML

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.