[Webkit-unassigned] [Bug 69988] [EFL] Change efl style local variables with WebKit coding Style.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 01:27:41 PDT 2011


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
         AssignedTo|webkit-unassigned at lists.web |gyuyoung.kim at samsung.com
                   |kit.org                     |
 Attachment #110975|                            |commit-queue-
               Flag|                            |

--- Comment #1 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-10-14 01:27:41 PST ---
Created an attachment (id=110975)
 --> (https://bugs.webkit.org/attachment.cgi?id=110975&action=review)

I make a prototype for this bug. Though I know well this patch is also very giant, I think it is better to change coding style as soon as possible. 

Major changes are as below,

  - Use ewkFrame instead of o parameter in ewk_frame.cpp.
  - Use ewkView instead of o parameter in ewk_view.cpp.
  - Use ewkTile instead of o parameter in ewk_tile_xxx.cpp.
  - Use smartData instead of sd parameter for Ewk_XXXX_Smart_Data struct.
  - Use width, height instead of w, h parameter.
  - Use scrollX, scrollY, scrollWidth, scrollHeight, centerX, centerY, deltaX, deltaY instead of sx, xy, sw, sh, cx, cy, dx, dy.
  - Use red, green, blue and alpha instead of r,g,b,a.
  - Remove "_" from parameter variable.

However, backing store's variables is almost encrypt. Backing Store guys should review this patch. Because, this patch is initial prototype, I will modify this patch according to efl guys's comments.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list