[Webkit-unassigned] [Bug 70084] Add WebAcceleratedContentLayer backed by a texture to support accelerated content hosting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70084


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110948|review?                     |review-
               Flag|                            |




--- Comment #4 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-10-13 21:55:35 PST ---
(From update of attachment 110948)
View in context: https://bugs.webkit.org/attachment.cgi?id=110948&action=review

> Source/WebKit/chromium/public/WebAcceleratedContentLayer.h:36
> +class WebAcceleratedContentLayer : public WebLayer {

isn't WebContentLayer accelerated too?  i'm not sure i understand what the
accelerated prefix means here.

perhaps WebExternalContentLayer would be a better name?  it seems like this
is intended to provide the embedder with a way to define a layer from a
given textureId.

perhaps it is obvious to everyone else, but could you explain what setFlip
and flip() are?  it looks like it is a property, but "flip" seems like a
verb to me, and yet you are using it like it is a thing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.