[Webkit-unassigned] [Bug 70074] New: Duplicate (Incorrect?) comparison in AccessibilityObject.cpp updateAXLineStartForVisiblePosition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70074

           Summary: Duplicate (Incorrect?) comparison in
                    AccessibilityObject.cpp
                    updateAXLineStartForVisiblePosition
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Accessibility
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rsleevi at chromium.org
                CC: rniwa at webkit.org, thakis at chromium.org


This was reported upstream to Chromium by way of PVS Studio ( http://www.viva64.com/en/b/0113/ ), Fragment N11

http://trac.webkit.org/browser/trunk/Source/WebCore/accessibility/AccessibilityObject.cpp?annotate=blame&rev=96973#L481

Line 487:
    while (true) {
        tempPosition = startPosition.previous();
        if (tempPosition.isNull() || tempPosition.isNull())
            break;
        Position p = tempPosition.deepEquivalent();

The bug is that the conditional checks if tempPosition.isNull() twice. It's not clear what is meant to be checked here - startPosition.isNull() ?

It was introduced in http://trac.webkit.org/changeset/92451

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.