[Webkit-unassigned] [Bug 69801] Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69801





--- Comment #8 from Kentaro Hara <haraken at chromium.org>  2011-10-13 15:37:40 PST ---
(In reply to comment #7)
> (From update of attachment 110833 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110833&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +        As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...].
> > +        We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839.
> 
> It's somewhat less obvious what CallWith means as an attribute of the whole interface.  I guess it makes sense for JavaScript where the interface *is* the constructor, but it probably makes somewhat less sense for other languages.  I still think this patch is a win though.
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1549
> > -    if ($dataNode->extendedAttributes->{"ConstructorWith"} && $dataNode->extendedAttributes->{"ConstructorWith"} eq "ScriptExecutionContext") {
> > +    if ($dataNode->extendedAttributes->{"CallWith"} && $dataNode->extendedAttributes->{"CallWith"} eq "ScriptExecutionContext") {
> 
> Do we not need a similar change to CodeGeneratorJSC.pm ?  I guess all these interfaces have JSCustomConstructor.

No, because [ConstructorWith] is the IDL that I introduced when I implemented [Constructor] IDL for V8, in other words, [ConstructorWith] is not yet implemented in JSC.

> 
> > Source/WebCore/fileapi/FileReader.idl:-41
> > -        ConstructorWith=ScriptExecutionContext,
> 
> This doesn't need CallWith ?  I guess not if we can compile without it.

It has CallWith. You can find it by clicking "20 below" link of FileReader.idl diff. I just removed ConstructorWith because FileReader.idl has both ConstructorWith and CallWith.

Thanks for reviewing these patches, Adam!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.