[Webkit-unassigned] [Bug 70060] New: DFG JIT should not be using ENABLE macro to enable features

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 13 14:49:04 PDT 2011


           Summary: DFG JIT should not be using ENABLE macro to enable
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: barraclough at apple.com

The ENABLE macro is only intended to be used to detect features that are configured in Platform.h.  Using its to detect settings defined in other headers is an error.

The problem is that the ENABLE macro checks if the value is defined, so will silently return false if you fail to include the header defining the switch.
This is not a problem if (1) the settings are defined in the same header that defines the macro that tests them, or (2) the header is included everywhere.  In the case of ENABLE settings defined in Platform.h, both are true!

To make this clear, add an explicit DFG_ENABLE macro.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list