[Webkit-unassigned] [Bug 69737] [Qt] GeolocationClient cleanups

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 13 10:19:08 PDT 2011


--- Comment #7 from Simon Hausmann <hausmann at webkit.org>  2011-10-13 10:19:09 PST ---
(From update of attachment 110560)
View in context: https://bugs.webkit.org/attachment.cgi?id=110560&action=review

Urgh, this is one mess of #ifdefs ;(. An alternative would be to split out the code into two files *Qt4 and *Qt5.

Adenilson, do you mind doing another round with Kenneth's suggested changes at least? (unless you prefer the suggested split)

> Source/WebKit/qt/QtWebKit.pro:287
> +qt5: QT += location

Please indent this line :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list